[FIRRTL] Add layer block support to AddSeqMemPorts #7599
+129
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the AddSeqMemPorts pass to support layers. Namely, this will now allow for input ports to be added to memories declared under layer block. If a user tries to add output ports, then produce an error. Generally, this entire pass likely doesn't make sense for layer blocks at all. I.e., this pass is entirely about adding MBIST ports to memories. Memories that are declared under layerblocks are likely only for verification use and adding MBIST ports to these doesn't really make sense. Nonetheless, it is reasonable to have this pass do something sane if it encounters a user request like this. This made a small change to the pass output where the connects created are placed immediately following the memory instance. This is necessary to create the connects inside the layer blocks. However, it is also slightly better output than before. (This changed one test superficially.) Signed-off-by: Schuyler Eldridge <[email protected]>
|
This does not handle some of the weirder things that could be going on here related to the memory metadata file. This file is intended to show where these extra ports are on which memory. However, the memory may be moved under a layer block bind file. It may be better to instead completely disallow this pass for memories under layer blocks. It just really doesn't make sense to be adding MBIST ports to memories which are basically design verification collateral. Alternative way of arguing this, because layers are new, nobody is using this behavior, thereby we can punt on what to do here until there is an actual user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the AddSeqMemPorts pass to support layers. Namely, this will now allow for input ports to be added to memories declared under layer block. If a user tries to add output ports, then produce an error.
Generally, this entire pass likely doesn't make sense for layer blocks at all. I.e., this pass is entirely about adding MBIST ports to memories. Memories that are declared under layerblocks are likely only for verification use and adding MBIST ports to these doesn't really make sense. Nonetheless, it is reasonable to have this pass do something sane if it encounters a user request like this.
This made a small change to the pass output where the connects created are placed immediately following the memory instance. This is necessary to create the connects inside the layer blocks. However, it is also slightly better output than before. (This changed one test superficially.)